[U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

[Heiko Schocher]

Hello Scott,

Scott Wood wrote:
> Sorry for the delay, didn't see this the first time around -- just
> noticed it in patchwork.

No problem. Thanks for the review!

> On Sat, Jul 16, 2011 at 12:06:44AM -0000, Heiko Schocher wrote:
>> @@ -739,6 +743,10 @@ U_BOOT_CMD(
>>  	"nand env.oob set off|partition - set enviromnent offset\n"
>>  	"nand env.oob get - get environment offset"
>>  #endif
>> +#ifdef CONFIG_CMD_NAND_HWFUNC
>> +	"\n"
>> +	"nand hwfunc " CONFIG_CMD_NAND_HWFUNC "\n"
>> +#endif
> 
> Why not just define hardware-specific commands at whatever scope they
> makes sense (board code, controller driver, etc.), rather than add a
> generic hook here?

Hmm... because if I define a hw specific command for example at
soc scope, it is not a nand subcommand ... and I like to have all
nand commands (I use it for switching between different read/write
functions) accessable under "nand ..." from the u-boot shell ...
I don;t like to have all over the code randomised some nand commands ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany