[U-Boot] [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

[Wolfgang Denk]

Dear Chander Kashyap,

In message <CANuQgHFVBv-b5ecRqkrkcpPOwx2umpBR_RFPRx-c0fbvLmxNxQ at mail.gmail.com> you wrote:
> 
> > > +void dram_init_banksize(void)
> > > +{
> > > +     gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> > > +     gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> > > +     gd->bd->bi_dram[1].start = PHYS_SDRAM_2;
> > > +     gd->bd->bi_dram[1].size = PHYS_SDRAM_2_SIZE;
> > > +     gd->bd->bi_dram[2].start = PHYS_SDRAM_3;
> > > +     gd->bd->bi_dram[2].size = PHYS_SDRAM_3_SIZE;
> > > +     gd->bd->bi_dram[3].start = PHYS_SDRAM_4;
> > > +     gd->bd->bi_dram[3].size = PHYS_SDRAM_4_SIZE;
> > > +}
> >
> > How do you detect memory issues in one of the memory banks, say, a
> > memory error in bank 3?
> >
>  get_ram_size will take care for it.

How so?  You are setting these to fixed, predefined values.

If get_ram_size() for bank 3 returns a size of 0, you will still set
the size to PHYS_SDRAM_3_SIZE here.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1000 pains                                              = 1 Megahertz