[U-Boot] at91rm9200dk broken/patches?

[Andreas Bießmann]

Dear Rick Bronson,

Am 03.08.2011 18:10, schrieb Rick Bronson:
> Hi Reinhard,
> 
>   Did you ever get the email below?  I never heard back from anyone on
> this.

Sorry, did not see this mail.


> From rick Tue Jan 18 22:32:15 -0800 2011
> To: Reinhard Meyer <u-boot at emk-elektronik.de>
> CC: albert at aribaud.net, reinhard.meyer at emk-elektronik.de
> In-reply-to: <4D34A61F.1030907 at emk-elektronik.de> (message from Reinhard Meyer
> 	on Mon, 17 Jan 2011 21:27:11 +0100)
> Subject: Re: U-Boot support for board(s) AT91RM9200DK
> References: <20101127215901.95380220235C at lilith> <E1PN7fz-0002QA-6P at amazonia.comcast.net> <4CF3E933.8070901 at aribaud.net> <E1PN8NO-0002gI-9Z at amazonia.comcast.net> <4D32AE6E.1070900 at aribaud.net> <E1Peqrc-0001iz-Fb at amazonia.comcast.net> <4D34627A.7080006 at aribaud.net> <E1PesXV-0005Eg-9d at amazonia.comcast.net> <4D348052.4020401 at aribaud.net> <4D34A61F.1030907 at emk-elektronik.de>
> 
> Hi All,
> 
>   Here is what I've done so far:
> 
> git clone git://git.denx.de/u-boot-atmel.git
> cd u-boot-atmel
> git checkout -b rework101229
> 
>  - used CodeSourcery/Sourcery_G++_Lite:
> 
> /u-boot-atmel> /opt/CodeSourcery/Sourcery_G++_Lite/bin/arm-none-linux-gnueabi-gcc --version
> arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2010q1-202) 4.4.1
> 
>   Hopefully this compiler is okay, please tell me if it's not.

should work. Maybe you run into trouble cause of missing armv4 support
in the toolchain. There are workarounds, just let u-boot build its own
libgcc stuff -> 'USE_PRIVATE_LIBGCC'.

>  - looked at:
> 
> commit 0693923cd240f5d401be0a53cddcf0fb1d9ad9d3 in the current u-boot
> 
>  - Make a bunch of changes but still have 2 warnings (see
>    http://www.efn.org/~rick/pub/build.log):
> 
> cpu.c:37: warning: #warning Your board is using legacy AT91RM9200 SoC access. Please update!

Well, please update this board to use the new arm920t/at91 SoC code, see
at91rm9200ek for example.

> at91_emac.c:487: warning: dereferencing type-punned pointer will break strict-aliasing rules

fixed in 2321bfe425385494da8739d7d7e9dd3a5ca18a84

>   What should I do about these?
> 
>   I made a patch file, please check it over.
>   http://www.efn.org/~rick/pub/uboot.diff

At least these steps are missing:
 - configure to use arm920t/at91, not arm920t/at91rm9200 (-> boards.cfg)
 - set correct USART in config
 - adopt includes in board file

best regards,

Andreas Bießmann