[U-Boot] [PATCH 1/2] atmel: update at91sam9m10g45 SoC support to new style

Reinhard Meyer u-boot at emk-elektronik.de
Thu Aug 4 15:59:18 CEST 2011


Dear Thomas Petazzoni,
> Based on earlier work by Alex Waterman <awaterman at dawning.com>.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  .../cpu/arm926ejs/at91/at91sam9m10g45_devices.c    |   28 ++--
>  arch/arm/include/asm/arch-at91/at91sam9g45.h       |   12 ++
>  .../arm/include/asm/arch-at91/at91sam9g45_matrix.h |  194 +++++++-------------
>  3 files changed, 94 insertions(+), 140 deletions(-)

This patch still has the same issues I complained about at

http://patchwork.ozlabs.org/patch/102811/

please fix them. Also your *_matrix.h is space corrupted (indentation
done by space not tab). Tabs must be used!

Please, and again, refer to the templates done in the 926x SoCs.

WARNING: please, no space for starting a line, 
				excluding comments
#184: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:21:
+       u32             mcfg[16];$

WARNING: please, no space for starting a line, 
				excluding comments
#185: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:22:
+       u32             scfg[16];$

WARNING: please, no space for starting a line, 
				excluding comments
#186: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:23:
+       u32             pras[16][2];$

WARNING: please, no space for starting a line, 
				excluding comments
#187: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:24:
+       u32             mrcr;           /* 0x100 Master Remap Control
*/$

WARNING: please, no space for starting a line, 
				excluding comments
#188: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:25:
+       u32             filler[3];$

WARNING: please, no space for starting a line, 
				excluding comments
#189: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:26:
+       u32             tcmr;$

WARNING: please, no space for starting a line, 
				excluding comments
#190: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:27:
+       u32             filler2;$

WARNING: please, no space for starting a line, 
				excluding comments
#191: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:28:
+       u32             ddrmpr;$

WARNING: please, no space for starting a line, 
				excluding comments
#192: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:29:
+       u32             filler3[3];$

WARNING: please, no space for starting a line, 
				excluding comments
#193: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:30:
+       u32             ebicsa;$

WARNING: please, no space for starting a line, 
				excluding comments
#194: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:31:
+       u32             filler4[47];$

WARNING: please, no space for starting a line, 
				excluding comments
#195: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:32:
+       u32             wpmr;$

WARNING: please, no space for starting a line, 
				excluding comments
#196: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:33:
+       u32             wpsr;$

WARNING: line over 80 characters
#315: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:66:
+#define AT91_MATRIX_RCB0                (1 << 0)        /* Remap
Command for AHB Master 0 (ARM926EJ-S Instruction Master) */

WARNING: line over 80 characters
#316: FILE: arch/arm/include/asm/arch-at91/at91sam9g45_matrix.h:67:
+#define AT91_MATRIX_RCB1                (1 << 1)        /* Remap
Command for AHB Master 1 (ARM926EJ-S Data Master) */

total: 0 errors, 15 warnings, 312 lines checked

U-Boot-1-2-atmel-update-at91sam9m10g45-SoC-support-to-new-style.patch
has style problems, please review.

Best Regards,
Reinhard



More information about the U-Boot mailing list