[U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.

Wolfgang Denk wd at denx.de
Thu Aug 4 22:14:06 CEST 2011


Dear Scott Wood,

In message <4E3AF62B.8080605 at freescale.com> you wrote:
>
> Again, I think "nand hwfunc" conveys little information about what it's 
> actually going to do, versus something like:
> 
> => nandrbl
> off

I agree with Heiko that NAND related commands should be implemented as
subcommands of the "nand" command.

Havong "nand <subcommand>" and "nandrbl" at the same time is not
acceptable to me - that should be changed into "nand rbl".

> At least "nand hwfunc type" or "nand hwfunc rbl" would be more 
> informative, but I question the benefit that the verbosity buys us.

I agree that "hwfunc" is an unlucky name.

> So now it's "nand hwfunc ctrl type rbl"?  Just to avoid grepping for 
> U_BOOT_CMD?

No. I would not like this either.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
War isn't a good life, but it's life.
	-- Kirk, "A Private Little War", stardate 4211.8


More information about the U-Boot mailing list