[U-Boot] [PATCH v3] OMAP3: Add DSS driver for OMAP3

[Jason Kridner]

On Thu, Aug 4, 2011 at 4:54 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Jason Kridner,
>
> In message <1303343572-19972-25-git-send-email-jkridner at beagleboard.org> you wrote:
>> From: Syed Mohammed Khasim <khasim at ti.com>
>>
>> Supports dynamic panel configuration
>> Supports dynamic tv standard selection
>> Adds support for DSS register access through generic APIs
>>
>> Incorporated DSS register access using structures.
>
> I apologize for the late review...
>
> ...
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-omap3/dss.h
>> @@ -0,0 +1,173 @@
> ...
>> + * Referred to Linux DSS driver files for OMAP3
>
> Sorry, but we need exact attribution.  Please see bullet # 4 at
> http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign

k.

>
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation's version 2 of
>> + * the License.
> ...
>
> Sorry, but we need GPL v2+ (i. e. the "or any later version" clause)
> [ibidem, bullet # 3]

k

>
> ...
>> diff --git a/drivers/video/omap3_dss.c b/drivers/video/omap3_dss.c
>> new file mode 100644
>> index 0000000..69c705a
>> --- /dev/null
>> +++ b/drivers/video/omap3_dss.c
> ...
>> + * Referred to Linux DSS driver files for OMAP3
>
> See above.
>
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation's version 2 of
>> + * the License.
>
> See above.
>
> Can you please provide proper attribution, and try to get the
> licensing fixed?

Joel, since there seems to be some interest in this patch, can you
perform the clean-up on this one and submit it (tested in isolation to
the other patches being cleaned-up for upstreaming)?  Perhaps it is
wrong for me to assume you'll have he next free minute?

>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The only perfect science is hind-sight.
>