[U-Boot] [PATCH v2] MAKEALL ARM: Use boards.cfg

Reinhard Meyer u-boot at emk-elektronik.de
Fri Aug 5 22:40:50 CEST 2011


Dear Dirk Behme,

> From: Dirk Behme <dirk.behme at googlemail.com>
> 
> Use the boards from boards.cfg for building ./MAKEALL ARMx.
> 
> Note: ARM10 systems don't seem to exist any more.

Wrong: a simple grep shows that those are still in Makefile.

> 
> Signed-off-by: Dirk Behme <dirk.behme at googlemail.com>
> 
> ---
> Changes in v2: Instead of dublicating the missing boards from
> boards.cfg to MAKEALL, use the boards defined in boards.cfg
> directly.

This sentence does not make sense to me...
How can something that is missing be duplicated?
I think you were wanting to say: "remove all boards that are in
boards.cfg from MAKEALL"

> 
>  MAKEALL |  134 ++++------------------------------------------------------------
>  1 file changed, 9 insertions(+), 125 deletions(-)

Are all those boards removed here in boards.cfg?
Answer: NO
Are none of them still in Makefile?
Answer: NO

Remember:
1. boards must either be in Makefile OR boards.cfg
2. boards that are still in Makefile MUST BE in MAKEALL
3. boards that are in boards.cfg SHOULD NOT be in MAKEALL

Of the boards removed from MAKEALL by your patch, I found several in
Makefile but not in boards.cfg.

By removing them from MAKEALL they will not be built any more in MAKEALL
runs and this would hide their possible brokenness!

Best Regards,
Reinhard




More information about the U-Boot mailing list