[U-Boot] [PATCH V8 8/9] omap3: implement boot parameter saving

[Simon Schwarz]

On 08/08/2011 10:44 AM, Aneesh V wrote:
> Hi Simon,
>
> On Monday 08 August 2011 01:33 PM, Simon Schwarz wrote:
>> Hi Aneesh,
>>
>> On 08/05/2011 09:41 AM, Aneesh V wrote:
>>> Hi Simon,
>>>
>>> On Tuesday 02 August 2011 09:29 PM, Simon Schwarz wrote:
>>>> Implements the saving of boot params passed by OMAP3 ROM code.
>>>>
>>>> Signed-off-by: Simon Schwarz<simonschwarzcor at gmail.com>
>>>> ---
>>>> Didn't exist before V8
>>>> ---
>>>> arch/arm/cpu/armv7/omap-common/spl.c | 6 +++++-
>>>> arch/arm/cpu/armv7/omap3/lowlevel_init.S | 9 +++++++--
>>>> arch/arm/include/asm/omap_common.h | 10 ++++++++++
>>>> 3 files changed, 22 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c
>>>> b/arch/arm/cpu/armv7/omap-common/spl.c
>>>> index 53d10bf..3dd8e0d 100644
>>>> --- a/arch/arm/cpu/armv7/omap-common/spl.c
>>>> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
>>>> @@ -194,8 +194,12 @@ static void mmc_load_image(void)
>>>> printf("spl: mmc init failed: err - %d\n", err);
>>>> hang();
>>>> }
>>>> -
>>>> +/* For OMAP3 there is no automatic boot mode detection */
>>>> +#ifdef CONFIG_OMAP34XX
>>>> + boot_mode = CONFIG_SYS_MMC_SD_BOOTMODE;
>>>> +#else
>>>> boot_mode = omap_boot_mode();
>>>> +#endif
>>>
>>> Why boot mode detection is not supported? You seem to be saving
>>> bootparams below that has boot mode information. Why don't you use it?
>>>
>>
>> Because you wrote: "What I have done for OMAP4 will not work for OMAP3.
>> For OMAP3 you will
>> get only the boot-device(eMMC, MMC/SD, nand etc) and *not* the
>> bootmode(raw
>> vs FAT)."
>> http://mid.gmane.org/4E256783.5080601@ti.com
>>
>> Did I understand you wrong here?
>
> Sorry for the noise. I mistook 'boot_mode' for 'boot_device'. Anyway,
> instead of hard-coding this, I would prefer the following approach
> taken by x-loader.
>
> 1. For eMMC - raw mode
> 2. For external MMC/SD card - FAT mode.

done.

> best regards,
> Aneesh

Regards
Simon