[U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC Armada100
Ajay Bhargav
ajay.bhargav at einfochips.com
Wed Aug 10 10:32:47 CEST 2011
----- "Prafulla Wadaskar" <prafulla at marvell.com> wrote:
> You should move entire contents of gpio.h in mvgpio.h within #ifdef
> CONFIG_SHEEVA_88SV331xV5, so just mvgpio.c,mvgpio.h,Makefile will add
> armada100 gpio driver support in more generic way.
>
> > I have no idea about number of banks in other SOCs with same core.
>
> No need to worry, at this moment this driver will be supporting
> 88SV331xv5 core only.
>
> Regards..
> Prafulla . .
>
I think its better to just keep Armada100 related stuff in gpio.h and
I will do the following suggested changes.
> > {
> > Const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register
> > bank offsets */
> > return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
> > }
Regards,
Ajay Bhargav
More information about the U-Boot
mailing list