[U-Boot] [PATCH v5 1/2] gpio: Add GPIO driver framework for Marvell SoCs
Lei Wen
adrian.wenl at gmail.com
Wed Aug 10 15:58:53 CEST 2011
Hi Ajay,
On Wed, Aug 10, 2011 at 7:34 PM, Ajay Bhargav
<ajay.bhargav at einfochips.com> wrote:
> This patch adds generic GPIO driver framework support for Marvell SoCs.
>
> To enable GPIO driver define CONFIG_MARVELL_GPIO and for GPIO commands
> define CONFIG_CMD_GPIO in your board configuration file.
>
> Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> ---
> Changes for v2:
> - mvgpio.h removed
> - function get_gpio_base moved to gpio.h
> - error messages added
> Changes for v3:
> - Added mvgpio.h for common define based on CPU core subversion.
> Changes for v4:
> - not changed
> Changes for v5:
> - Added change history
>
> drivers/gpio/Makefile | 1 +
> drivers/gpio/mvgpio.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++
> include/mvgpio.h | 77 +++++++++++++++++++++++++++++++++
> 3 files changed, 192 insertions(+), 0 deletions(-)
> create mode 100644 drivers/gpio/mvgpio.c
> create mode 100644 include/mvgpio.h
>
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index 62ec97d..beca1da 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -27,6 +27,7 @@ LIB := $(obj)libgpio.o
>
> COBJS-$(CONFIG_AT91_GPIO) += at91_gpio.o
> COBJS-$(CONFIG_KIRKWOOD_GPIO) += kw_gpio.o
> +COBJS-$(CONFIG_MARVELL_GPIO) += mvgpio.o
> COBJS-$(CONFIG_MARVELL_MFP) += mvmfp.o
> COBJS-$(CONFIG_MXC_GPIO) += mxc_gpio.o
> COBJS-$(CONFIG_PCA953X) += pca953x.o
> diff --git a/drivers/gpio/mvgpio.c b/drivers/gpio/mvgpio.c
> new file mode 100644
> index 0000000..0cc8ed7
> --- /dev/null
> +++ b/drivers/gpio/mvgpio.c
> @@ -0,0 +1,114 @@
> +/*
> + * (C) Copyright 2011
> + * eInfochips Ltd. <www.einfochips.com>
> + * Written-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> + *
> + * (C) Copyright 2010
> + * Marvell Semiconductor <www.marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/errno.h>
> +#include <asm/gpio.h>
> +
> +#ifndef MV_MAX_GPIO
> +#define MV_MAX_GPIO 128
> +#endif
> +
> +int gpio_request(int gp, const char *label)
> +{
> + if (gp >= MV_MAX_GPIO) {
> + printf("%s: Invalid GPIO requested %d\n", __func__, gp);
> + return -EINVAL;
> + }
> + return 0;
> +}
> +
> +void gpio_free(int gp)
> +{
> +}
> +
> +void gpio_toggle_value(int gp)
> +{
> + gpio_set_value(gp, !gpio_get_value(gp));
> +}
> +
> +int gpio_direction_input(int gp)
> +{
> + struct gpio_reg *gpio_reg_bank;
> +
> + if (gp >= MV_MAX_GPIO) {
> + printf("%s: Invalid GPIO %d\n", __func__, gp);
> + return -EINVAL;
> + }
> +
> + gpio_reg_bank = get_gpio_base(GPIO_TO_REG(gp));
> + writel(GPIO_TO_BIT(gp), &gpio_reg_bank->gcdr);
> + return 0;
> +}
> +
> +int gpio_direction_output(int gp, int value)
> +{
> + struct gpio_reg *gpio_reg_bank;
> +
> + if (gp >= MV_MAX_GPIO) {
> + printf("%s: Invalid GPIO %d\n", __func__, gp);
> + return -EINVAL;
> + }
> +
> + gpio_reg_bank = get_gpio_base(GPIO_TO_REG(gp));
> + writel(GPIO_TO_BIT(gp), &gpio_reg_bank->gsdr);
> + gpio_set_value(gp, value);
> + return 0;
> +}
> +
> +int gpio_get_value(int gp)
> +{
> + struct gpio_reg *gpio_reg_bank;
> + u32 gp_val;
> +
> + if (gp >= MV_MAX_GPIO) {
> + printf("%s: Invalid GPIO %d\n", __func__, gp);
> + return -EINVAL;
> + }
> +
> + gpio_reg_bank = get_gpio_base(GPIO_TO_REG(gp));
> + gp_val = readl(&gpio_reg_bank->gplr);
> +
> + return GPIO_VAL(gp, gp_val);
> +}
> +
> +void gpio_set_value(int gp, int value)
> +{
> + struct gpio_reg *gpio_reg_bank;
> +
> + if (gp >= MV_MAX_GPIO) {
> + printf("%s: Invalid GPIO %d\n", __func__, gp);
> + return;
> + }
> +
> + gpio_reg_bank = get_gpio_base(GPIO_TO_REG(gp));
> + if (value)
> + writel(GPIO_TO_BIT(gp), &gpio_reg_bank->gpsr);
> + else
> + writel(GPIO_TO_BIT(gp), &gpio_reg_bank->gpcr);
> +}
> diff --git a/include/mvgpio.h b/include/mvgpio.h
> new file mode 100644
> index 0000000..768e94c
> --- /dev/null
> +++ b/include/mvgpio.h
> @@ -0,0 +1,77 @@
> +/*
> + * (C) Copyright 2011
> + * eInfochips Ltd. <www.einfochips.com>
> + * Written-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> + *
> + * (C) Copyright 2010
> + * Marvell Semiconductor <www.marvell.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef __MVGPIO_H__
> +#define __MVGPIO_H__
> +
> +#include <common.h>
> +
> +#define GPIO_SET 1
> +#define GPIO_CLR 0
> +
You should remove these two define, or we would met build error as:
cmd_gpio.c:20: error: expected identifier before numeric constant
cmd_gpio.c: In function 'do_gpio':
cmd_gpio.c:49: error: 'GPIO_CLEAR' undeclared (first use in this function)
cmd_gpio.c:49: error: (Each undeclared identifier is reported only once
cmd_gpio.c:49: error: for each function it appears in.)
cmd_gpio.c:50: error: 'GPIO_TOGGLE' undeclared (first use in this function)
Except this, other looks good to me, and I have verify the reset of
patch on mmp3 board.
Thanks,
Lei
More information about the U-Boot
mailing list