[U-Boot] [PATCH 2/9] mx1: add i2c registers

[Stefano Babic]

On 08/10/2011 10:33 PM, Eric Jarrige wrote:
> Add i2c registers for Freescale imx1/L/S
> 
> Signed-off-by: Eric Jarrige <eric.jarrige at armadeus.org>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
>  arch/arm/include/asm/arch-imx/imx-regs.h |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
> 

Hi Eric,

>  
> +/*
> + * I2C module
> + */
> +#define IADR   __REG(IMX_I2C_BASE + 0x000) /* I2C Address Register */
> +#define IFDR   __REG(IMX_I2C_BASE + 0x004) /* I2C Frequency Divider Register*/
> +#define I2CR   __REG(IMX_I2C_BASE + 0x008) /* I2C Control Register */
> +#define I2SR   __REG(IMX_I2C_BASE + 0x00C) /* I2C Status Register */
> +#define I2DR   __REG(IMX_I2C_BASE + 0x010) /* I2C Data I/O Register */

See my comments on your [PATCH 3/9] apf9328: Add Armadeus Project board
APF9328. Access to registers must be done via accessors and __REG macro
should be removed.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================