[U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command

York Sun yorksun at freescale.com
Thu Aug 11 17:03:22 CEST 2011


On Thu, 2011-08-11 at 09:55 -0500, Tabi Timur-B04825 wrote:
> York Sun wrote:
> > -		e.mac_count = simple_strtoul(argv[2], NULL, 16);
> > +		e.mac_count = simple_strtoul(argv[2], NULL, 10);
> 
> You forgot the MAC address index.  There's another use of strtoul in the 
> code that needs to be fixed.

I didn't forget the index. It is base 10 already.

> 
> Also, if you use "0" instead of "10", then it should be able to handle 
> hex as well, just in case someone wants to use it.

That's not a bad idea. I will change to "0" but leave the mac address as
hex.

York




More information about the U-Boot mailing list