[U-Boot] [PATCH 6/9] mx1: improve PLL freq computation
Eric Jarrige
eric.jarrige at armadeus.org
Fri Aug 12 02:28:31 CEST 2011
Hi Stefano,
>
> On 11 août 2011, at 11:22, Stefano Babic wrote:
>
>> On 08/10/2011 10:33 PM, Eric Jarrige wrote:
>>> Improve PLL freq computation by using the full resolution of the PLL registers
>>
>> Hi Eric,
>>
>>> + return (2*(u64)sys_clk_freq * (mfi*(mfd+1) + mfn))/((mfd+1)*(pd+1));
>>> +}
>>>
>>> - return (2*(CONFIG_SYSPLL_CLK_FREQ>>10)*( (mfi<<10) + (mfn<<10)/(mfd+1)))/(pd+1);
>>
>> Please run checkpatch on your patches for V2. I have not yet done, but
>> this line will report missing spaces.
>>
> I did it and had no error and no warning:
>
Here is the report of checkpatch.pl on [PATCH 6/9] this time :
armadeus/buildroot/output/build/linux-3.0.1/scripts/checkpatch.pl ../../../target/u-boot/git/06-mx1-pllclk.patch
total: 0 errors, 0 warnings, 44 lines checked
../../../target/u-boot/git/06-mx1-pllclk.patch has no obvious style problems and is ready for submission.
Cheers,
Eric
More information about the U-Boot
mailing list