[U-Boot] [PATCH v5 1/3] gpio: Move common gpio.h to include/asm-generic

[Mike Frysinger]

On Friday, August 12, 2011 04:11:22 Joe Hershberger wrote:
> +int gpio_request(int gp, const char *label);
> +void gpio_free(int gp);
> +int gpio_direction_input(int gp);
> +int gpio_direction_output(int gp, int value);
> +int gpio_get_value(int gp);
> +void gpio_set_value(int gp, int value);

please use "unsigned gpio".  this is what linux does and what most 
implementations should be doing (since sane people will pull from linux).

> +void gpio_toggle_value(int gp);

this is not currently part of the generic gpio api.  this should stay in arm's 
asm/gpio.h for now, or not implement it at all.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110812/4177be54/attachment.pgp