[U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function

[Lan Chunhe]

On Mon, 15 Aug 2011 08:08:04 +0800, Tabi Timur-B04825  
<B04825 at freescale.com> wrote:

> On Thu, Aug 11, 2011 at 11:18 PM, Chunhe Lan <Chunhe.Lan at freescale.com>  
> wrote:
>
>> +/*
>> + * Sets the specified node's status to the value contained in "status".
>> + * If the first character of the specified path is "/" then we use
>> + * alias as a path. Otherwise, we look for an alias of that name.
>> + */
>> +void fdt_set_node_status(void *fdt, const char *alias, const char  
>> *status)
>> +{
>> +       const char *path = fdt_get_alias(fdt, alias);
>> +
>> +       if (!path)
>> +               path = alias;
>> +
>> +       do_fixup_by_path(fdt, path, "status", status, strlen(status) +  
>> 1, 1);
>> +}
>
> If you're going to take some internal code and post it upstream, you
> should at least use the latest version of that code.  The latest
> version of this function has this comment:
>
> /*
>  * Given an alias or a path for a node, set the status of that node.
>  *
>  * If 'alias' is not a valid alias, then it is treated as a full path to  
> the
>  * node.  No error checking is performed.
>  *
>  * This function is normally called to set the status for a virtual MDIO  
> node.
>  */
>
> However, since you're moving this function to fdt_support, the last
> sentence should be dropped.

    OK.
    Thanks.

>> +++ b/include/fdt_support.h
>> @@ -2,6 +2,8 @@
>>  * (C) Copyright 2007
>>  * Gerald Van Baren, Custom IDEAS, vanbaren at cideas.com
>>  *
>> + * Copyright (C) 2011 Freescale Semiconductor, Inc.
>> + *
>
> Like Scott said, adding a single function prototype is not sufficient
> for a new copyright claim.  You have to add a significant amount of
> original code in order to add a new copyright line.

    Thanks for your comments.

    -Jack Lan