[U-Boot] [PATCH 12/12] da850: print DDR frequency from u-boot
Detlev Zundel
dzu at denx.de
Wed Aug 17 17:48:06 CEST 2011
Hi Stefano,
> On 08/17/2011 02:47 PM, Netagunte, Nagabhushana wrote:
>>> Maybe we should use this opportunity to align them? So what
>>> example should we follow? Hm, oldest code wins, so here we go:
>
> Never heard about this rule, but I agree it makes no sense to have
> differen commands.
You never heard about the principle of least surprise? Commands doing
the same thing should be called by the same name...
>>> [dzu at pollux u-boot-testing (master)]$ for f in
>>> arch/arm/cpu/arm1136/mx35/generic.c arch/arm/cpu/armv7/mx5/clock.c
>>> arch/powerpc/cpu/mpc512x/speed.c arch/powerpc/cpu/mpc83xx/speed.c ;
>>> do git describe --contains `git log --follow --pretty=format:%H $f
>>> | tail -1` ; done
>>> v2011.03-rc1~2^2~36
>>> v2010.03-rc1~35
>>> v1.3.0-rc4~69^2~1
>>> U-Boot-1_1_3~20^2~7
>>>
>>> So PowerPC wins ;) I.e. please use "clocks" as the command name,
>>> and I'd appreciate it if you send a patch changing the mx35 and mx5
>>> code.
>
> No luck here for i.MX ;-). I will send the patch to change the command
> name for i.MX.
Thanks in advance! I really hope that this command was never widely
used so we don't need to keep an deprecated alias for some time...
/me ducks and runs
Cheers
Detlev
--
There are two hard things in computer science: cache invalidation,
naming things, and off-by-one errors.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
More information about the U-Boot
mailing list