[U-Boot] [PATCH 1/2 V2] USB: Fix complaints about strict aliasing in OHCI-HCD

[Marek Vasut]

On Saturday, August 20, 2011 09:29:06 PM Mike Frysinger wrote:
> On Saturday, August 20, 2011 15:15:12 Marek Vasut wrote:
> >  	__u32 datab[4];
> > 
> > -	__u8 *data_buf = (__u8 *)datab;
> > +	union {
> > +		void *ptr;
> > +		__u8 *u8;
> > +		__u16 *u16;
> > +		__u32 *u32;
> > +	} databuf;
> > 
> > +	databuf.u32 = (__u32 *)datab;
> 
> i'm not sure this is correct, but i'm not really an expert on aliasing
> behavior.  i think the union should sit on top of the storage, and not hide
> the pointer casts.

And endianity comes into play here too ... that's where my brain started 
chugging a bit too. That's why I'd like to see other's opinion on this.

Cheers
> -mike