[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

Helmut Raiger helmut.raiger at hale.at
Mon Aug 22 17:00:15 CEST 2011


On 08/22/2011 04:00 PM, Marek Vasut wrote:
> +	u32 pdr0 = __REG(CCM_PDR0);
> Can't we do readl() here?
>
>> +
>> +	/* divided by HSP_PODF in PDR0 */
>> +	freq /= ((pdr0>>  11)&  0x7) + 1;
> Um, don't we have defined constants for those magic numbers already?
Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the 
code, which was in the file. The generic.c file for MX35 however is a 
different story.

To keep things simple, I suggest we leave it at that for now.

Helmut





--
Scanned by MailScanner.



More information about the U-Boot mailing list