[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

Helmut Raiger helmut.raiger at hale.at
Mon Aug 22 17:51:05 CEST 2011


On 08/22/2011 05:02 PM, Marek Vasut wrote:
>
>> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the
>> code, which was in the file. The generic.c file for MX35 however is a
>> different story.
>>
>> To keep things simple, I suggest we leave it at that for now.
> And noone's gonna fix it later. No please, define the proper constants please.
>
Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31 
files (2000+ lines) that use that kind of access, because I add 15 lines 
to one of them? There are some 50 other drivers and boards etc. that 
depend on imx-regs.h, which probably use these access methods as-well!

I'm not prepared to take this effort, sorry. After all this is 
_COSMETIC_, while this new mx3fb driver really works nicely ;-)
If anyone out there modifies these files, I'll definitely rebase the 
driver to it.

Helmut


--
Scanned by MailScanner.



More information about the U-Boot mailing list