[U-Boot] [PATCH] ns16550: change to allow 32 bit access to registers

[Wolfgang Denk]

Dear Dave Aldridge,

In message <1313589281-9789-1-git-send-email-fovsoft at gmail.com> you wrote:
> If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory
> mapped access will be used to read/write the uart registers.
> 
> This is especially useful for SoC devices that implement 16550
> compatible uarts but that have peripheral access width constraints.
> 
> Signed-off-by: Dave Aldridge <fovsoft at gmail.com>
> ---
>  drivers/serial/ns16550.c |    3 +++
>  include/ns16550.h        |    2 ++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 8eeb48f..fbb7165 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -19,6 +19,9 @@
>  #ifdef CONFIG_SYS_NS16550_PORT_MAPPED
>  #define serial_out(x,y)	outb(x,(ulong)y)
>  #define serial_in(y)	inb((ulong)y)
> +#elif defined(CONFIG_SYS_NS16550_MEM32)
> +#define serial_out(x,y) writel(x,y)
> +#define serial_in(y) 	readl(y)

Don't we have to consider endianess issues here?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An optimist believes we live in the best world possible; a  pessimist
fears this is true.