[U-Boot] [PATCH] add dm9000 eeprom read/write command

[Mike Frysinger]

On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote:
> On 22 août 2011, at 23:55, Mike Frysinger wrote:
> > On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote:
> >> +#if (!defined(CONFIG_DM9000_NO_SROM) && defined(CONFIG_DRIVER_DM9000))
> > 
> > why is this necessary ?
> 
> the methods dm9000_read_srom_word()/dm9000_write_srom_word() need these
> conditions to be compiled in dm9000x.c Therefore this avoid dead code
> and/or compilation failure if these conditions are not met.

my point is that it is user error to select CONFIG_CMD_DM9000EE but not select 
the DM9000 settings.  in your case, the user silently gets a build that makes 
no sense.  in my case, they're forced to fix things.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110823/87b1505c/attachment.pgp