[U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Anton Staaf robotboy at google.com
Tue Aug 23 20:46:27 CEST 2011


On Tue, Aug 23, 2011 at 11:36 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday, August 23, 2011 14:12:09 Anton Staaf wrote:
>> On Tue, Aug 23, 2011 at 10:30 AM, Mike Frysinger wrote:
>> > what about adding a new func like:
>> > #define dma_buffer_alloca(size)
>>
>> I generally avoid large allocations on the stack, they can confuse
>> virtual stack management and blow out small embedded stacks.
>
> oh, and that doesnt preclude also adding a dma_buffer_malloc(size).  it's just
> that all the cases here are already on the stack, so i was focusing on that.
> -mike
>

Yup, totally reasonable.  Lukasz, would you like to add the above
macro to your dcache cache line size patch?  Then we can change our
other patches to use it instead of memalign.

Thanks,
    Anton


More information about the U-Boot mailing list