[U-Boot] [PATCH v2] ext2: Cache line aligned partial sector bounce buffer

Wolfgang Denk wd at denx.de
Tue Aug 23 22:16:25 CEST 2011


Dear Mike Frysinger,

In message <201108231447.39934.vapier at gentoo.org> you wrote:
>
> then people would simply do:
> 	DMA_DECLARE_BUFFER(char, sec_buf, SECTOR_SIZE);
>
> but i'm not sure this is better than the proposed:
> 	char *sec_buf = dma_buffer_alloca(SECTOR_SIZE);
>
> i'd have to look at the code gcc generates to see if it is simply the same ... 
> in which case i'd stick with the latter as it's more natural to people.

Even if the code is different the former is so ugly that chances for
it to go into mainline are _really_ small.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just because your doctor has a name for your condition  doesn't  mean
he knows what it is.


More information about the U-Boot mailing list