[U-Boot] [PATCH] add dm9000 eeprom read/write command

[Eric Jarrige]

On 23 août 2011, at 16:21, Stefano Babic wrote:

> On 08/23/2011 03:42 PM, Mike Frysinger wrote:
>> On Tuesday, August 23, 2011 01:15:25 Eric Jarrige wrote:
>>> On 22 août 2011, at 23:55, Mike Frysinger wrote:
>>>> On Monday, August 22, 2011 17:37:42 Eric Jarrige wrote:
>>>>> +#if (!defined(CONFIG_DM9000_NO_SROM) && defined(CONFIG_DRIVER_DM9000))
>>>> 
>>>> why is this necessary ?
>>> 
>>> the methods dm9000_read_srom_word()/dm9000_write_srom_word() need these
>>> conditions to be compiled in dm9000x.c Therefore this avoid dead code
>>> and/or compilation failure if these conditions are not met.
>> 
>> my point is that it is user error to select CONFIG_CMD_DM9000EE but not select 
>> the DM9000 settings.  in your case, the user silently gets a build that makes 
>> no sense.  in my case, they're forced to fix things.
> 
> Agree. This is also my point to move this code inside the driver itself,
> where CONFIG_DRIVER_DM9000 is set (or it is not compiled).
> 

That makes sense - I can remove this line.

Best regards,
Eric