[U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

York Sun yorksun at freescale.com
Thu Aug 25 23:36:32 CEST 2011


Wolfgang,

On Thu, 2011-08-25 at 23:30 +0200, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <1314307500.29220.24.camel at oslab-l1> you wrote:
> >
> > Fixing all existing reference to ccs_ddr is a lot of work, comparing
> > with defining it for 83xx. There are many other typedefs in the very
> > same files. Would we fix all of them? I don't think so. The bottom of
> 
> well, if you could fix all of these while you are at it that would be
> just great :-)

There are nearly 400 typedefs for powerpc and 52 for immap_85xx.h, not
mentioned when they are used by .c files. Too many to fix.

> 
> > line is ccsr_ddr is not a new typedef.
> 
> But you are adding it new to this file.

I am introducing it to this file as it is already being used somewhere
else. If you are trying to enforce this new policy, please start with
brand new files/typedefs, as you pointed out in my another patch. I will
be happy to fix that.

York




More information about the U-Boot mailing list