[U-Boot] [PATCH V3 4/8] omap-common/spl: Add linux boot to SPL

[Andreas Bießmann]

Dear Simon

Am 26.08.2011 12:17, schrieb Simon Schwarz:
> On 08/25/2011 01:28 PM, Andreas Bießmann wrote:
>> Dear Simon,

<snip>

>>> +/* This function jumps to an image with argument. Normally an FDT or
>>> ATAGS
>>> + * image.
>>> + * arg: Pointer to paramter image in RAM
>>> + */
>>> +void jump_to_image_linux(void *arg)
>>> +{
>>> +    debug("Entering kernel arg pointer: 0x%X\n", arg);
>>> +    typedef void (*image_entry_arg_t)(int, int, void *)
>>> +        __attribute__ ((noreturn));
>>> +    image_entry_arg_t image_entry =
>>> +        (image_entry_arg_t) spl_image.entry_point;
>>> +    /* cleanup_before_linux(); */ /*write SPL function for that*/
>>> +    image_entry(0, CONFIG_SYS_SPL_MACHID, arg);
>>
>> the MACHID is saved in gd->bd, couldn't this be used here?
>> BTW: You missed setting CONFIG_SYS_SPL_MACHID in your board
>> configuration header in this patch. Where is it done?
>>
> 
> In SPL gd is not fully initialized.

I see ... but how about using existing CONFIG_MACH_TYPE then?

> CONFIG_SYS_SPL_MACHID is set see below in include/configs/devkit8000.h

Sorry for the noise, did not see it.

regards

Andreas Bießmann