[U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

[Joel A Fernandes]

On Wed, Aug 24, 2011 at 10:30 PM, Jason Kridner
<jkridner at beagleboard.org> wrote:
> On Wed, Aug 24, 2011 at 11:22 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
>> On Thursday, August 25, 2011 12:47:41 AM Joel A Fernandes wrote:
>>> From: Christian Spielberger <c.spielberger at bct-electronic.com>
>>>
>>> Signed-off-by: Joel A Fernandes <joelagnel at ti.com>
>>> Cc: "Eric Bأ�nard" <eric at eukrea.com>
>>> Cc: "Christian Spielberger" <c.spielberger at bct-electronic.com>
>>> ---
>>> Pushing this patch myself as no one else did.
>>>
>>> Previous discussions:
>>> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/105663/
>>> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101540/
>>>
>>>  board/ti/beagle/beagle.c |   10 +++++++++-
>>>  1 files changed, 9 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
>>> index 13fe39b..9d65e9e 100644
>>> --- a/board/ti/beagle/beagle.c
>>> +++ b/board/ti/beagle/beagle.c
>>> @@ -332,7 +332,15 @@ int misc_init_r(void)
>>>               setenv(expansion_config.env_var, expansion_config.env_setting);
>>>
>>>       twl4030_power_init();
>>> -     twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
>>> +     switch (get_board_revision()) {
>>> +     case REVISION_XM_C:
>>> +     case REVISION_C4:
>>> +             twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
>>> +             break;
>>> +     default:
>>> +             twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
>>> +             break;
>>> +     }
>
> Please excuse if this is a duplicate, but I'm configuring a new mail
> tool and I don't think my other message got sent.
>
> It is XM_A and XM_B that are odd-balls, so the correct code should be
> something like:
>
> +     switch (get_board_revision()) {
> +     case REVISION_XM_A:
> +     case REVISION_XM_B:
> +             twl4030_led_init(TWL4030_LED_LEDEN_LEDBON); /* LEDA
> signal set low */
> +             break;
> +     default:
> +             twl4030_led_init(TWL4030_LED_LEDEN_LEDAON |
> TWL4030_LED_LEDEN_LEDBON);
> +             break;


Hi Jason, I think it should be:


 +     switch (get_board_revision()) {
 +     case REVISION_XM_A:
 +     case REVISION_XM_B:
 +             twl4030_led_init(TWL4030_LED_LEDEN_LEDAON |
TWL4030_LED_LEDEN_LEDBON); /* LEDA
 signal set low */
 +             break;
 +     default:
 +             twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
 +             break;


Here's the equivalent in the linux kernel board file (default is
GPIOF_OUT_INIT_LOW)

        printk(KERN_INFO "OMAP3 Beagle Rev: xM Ax/Bx\n");
        omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
        beagle_config.usb_pwr_level = GPIOF_OUT_INIT_HIGH;


Let me know your comments.

thanks,
Joel