[U-Boot] [PATCH] Write MAC address whenever ethernet subsystem is initialized

[Mike Frysinger]

On Friday, August 26, 2011 08:43:34 Ingo van Lil wrote:
> @@ -261,11 +261,6 @@ int eth_initialize(bd_t *bis)
> 
>  				memcpy(dev->enetaddr, env_enetaddr, 6);
>  			}
> -			if (dev->write_hwaddr &&
> -				!eth_mac_skip(eth_number) &&
> -				is_valid_ether_addr(dev->enetaddr)) {
> -				dev->write_hwaddr(dev);
> -			}

removing this breaks the original reason write_hwaddr was added in the first 
place: people want the MAC programmed into the hardware even if they dont use 
the network.

we should probably add an explicit comment above this block so people dont try 
and "fix it" in the future.

> @@ -347,8 +342,14 @@ int eth_init(bd_t *bis)
>  	do {
>  		uchar env_enetaddr[6];
> 
> -		if (eth_getenv_enetaddr_by_index(eth_number, env_enetaddr))
> +		if (eth_getenv_enetaddr_by_index(eth_number, env_enetaddr)) {
>  			memcpy(dev->enetaddr, env_enetaddr, 6);
> +			if (dev->write_hwaddr &&
> +				!eth_mac_skip(eth_number) &&
> +				is_valid_ether_addr(dev->enetaddr)) {
> +				dev->write_hwaddr(dev);
> +			}
> +		}

this changes the current API between the common layer and the drivers.  i'm 
not saying that's a bad thing, just that we need to:
 (1) update the documentation (see doc/README.{drivers.eth,enetaddr})
 (2) update the drivers which manually call their write_hwaddr() in their 
init() func to no longer do that
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110826/227c79ac/attachment.pgp