[U-Boot] [PATCH V2] Global Data: Flagify have_console and env_valid

Graeme Russ graeme.russ at gmail.com
Sat Aug 27 00:36:49 CEST 2011


Hi Mike,

On 27/08/11 06:15, Mike Frysinger wrote:
> looks sane enough to me
> 
> when changing the global_data structure, do we need to bump the u-boot 
> standalone API number (XF_VERSION in exports.h) ?  and i vaguely recall global 
> data being passed to like Linux for some arches ?  although looking at the 
> number of #ifdef's in there, maybe that's already been a long lost battle.

That's a very interesting point. As far as I can tell, XF_VERSION needs to
be incremented when either the global data data structure is modified, or
if functions are added to or removed from the export list. Commit
3469424cb6d939c7aedf1e0efdec44a797c0a18c seems to confirm this:

  Note that the location of the standalone application jump table pointer
  in the global data structure is affected by this change, breaking
  execution of standalone applications compiled for previous versions of
  U-Boot.

So I think your point about the #ifdef's in global data is very
interesting. There are a _lot_ of board level defines (LCD, PCI, POST etc)

Question for Wolfgang I think :)

Regards,

Graeme


More information about the U-Boot mailing list