[U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

[Joel A Fernandes]

All,

I'm post a v2 now, please give ACKs, thanks :)

On Sat, Aug 27, 2011 at 11:19 AM, Jason Kridner
<jkridner at beagleboard.org> wrote:
> On Sat, Aug 27, 2011 at 9:51 AM, Eric Bénard <eric at eukrea.com> wrote:
>> Hi Joel,
>>
>> Le 27/08/2011 06:46, Joel A Fernandes a écrit :
>>>> The logic is wrong here.  I don't remember the polarity, but I do remember that it is
>>>> xM-A and xM-B that are the oddballs.  I believe this is the correct change:
>>>
>>> Hi Jason,
>>>
>>> LEDAON should be high for HUB power up on xMA and xMB, so in your code snip:
>>>
>>>>
>>>> +       switch (get_board_revision()) {
>>>> +       case REVISION_XM_A:
>>>> +       case REVISION_XM_B:
>>>> +               twl4030_led_init(TWL4030_LED_LEDEN_LEDBON);
>>>
>>> So this should be TWL4030_LED_LEDEN_LEDBON | TWL4030_LED_LEDEN_LEDAON
>>>
>>>> +               break;
>>>> +       default:
>>>> +               twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
>>>
>>> and, this should be TWL4030_LED_LEDEN_LEDBON
>>>
>>> Am I correct?
>>>
>> LEDA & LEDB are active low Open Drain outputs so enabling LEDAON bit in LEDEN
>> means LEDA output is at low level.
>
> Thanks for resolving that mystery.  I just figured out what I thought
> it should be by looking at the previous default, which should be the
> new default as well with only XM_A and XM_B are different.
>
>
>>
>> Eric
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>