[U-Boot] [PATCH 1/5 V2] PXA: Cleanup serial_pxa

[Wolfgang Denk]

Dear Marek Vasut,

In message <1314507088-1472-1-git-send-email-marek.vasut at gmail.com> you wrote:
> * Cleanup register definitions by introducing new regs-uart.h, compliant with
>   rest of U-Boot.
> * Remove old register definitions from pxa-regs.h
> * Convert serial_pxa to new regs-uart.h
> * Cleanup serial_pxa
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  arch/arm/include/asm/arch-pxa/pxa-regs.h  |  111 -------
>  arch/arm/include/asm/arch-pxa/regs-uart.h |  109 +++++++
>  drivers/serial/serial_pxa.c               |  464 ++++++++++++-----------------
>  3 files changed, 297 insertions(+), 387 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-pxa/regs-uart.h
> 
> V2: Add missing regs-uart.h

Your patch stacks are a mess.  It's impossible for mne to tell what
you actually intend.

So we have now tow series:

1: [PATCH 1/6] PXA: Fix Lubbock, remove redundant parenthesis
1: [PATCH 2/6] PXA: Fix CSB226, fix monitor length
1: [PATCH 3/6] USB: Fix complaints about strict aliasing in OHCI-HCD
1: [PATCH 4/6] IDE: Fix complaints about strict aliasing in cmd_ide.c
1: [PATCH 5/6] PXA: Cleanup serial_pxa
1: [PATCH 6/6] PXA: vpac270: Remove re-defined CONFIG_SYS_TEXT_BASE

2: [PATCH 1/5 V2] PXA: Cleanup serial_pxa
2: [PATCH 3/5] PXA: vpac270: Enable the new generic MMC driver
2: [PATCH 2/5] PXA: Add MMC driver using the generic MMC framework
2: [PATCH 4/5 RESEND] USB: Fix complaints about strict aliasing in OHCI-HCD
2: [PATCH 5/5 RESEND] IDE: Fix complaints about strict aliasing in cmd_id


It appears as if "2: [PATCH 1/5 V2]" might be a replacement for "1:
[PATCH 5/6]" - but then, it does not contain any of the required
In-reply-to: and/or References: headers.

It appears as if "2: [PATCH 4/5 RESEND]" and "2: [PATCH 5/5 RESEND]"
might be (unchanged ???) Repostings of ""1: [PATCH 3/6]" resp. "1:
[PATCH 4/6]" - but then, why do you repost these at all? You are not
supposed to resubmit patches without changes.

Also, it does not appears as if the whole 2nd series was a
replacement / update for the first, as there are no equivalents for
"1: [PATCH 1/6]" or "1: [PATCH 2/6]'.


All in all, this is a terrible mess, and in violation of patch
submission rules.


Please consider both patch series NAKed.


Fix your code and clean up as needed, then repost but please with
proper version information, proper change logs, and proper mail
threading.


Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Have you lived in this village all your life?"        "No, not yet."