[U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100
Mike Frysinger
vapier at gentoo.org
Mon Aug 29 07:30:13 CEST 2011
On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote:
> ----- "Mike Frysinger" <vapier at gentoo.org> wrote:
> > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote:
> > > + darmdfec = malloc(sizeof(struct armdfec_device));
> > > + if (!darmdfec)
> > > + goto error;
> >
> > if this first one fails, we jump to:
> > > +error:
> > > + free(darmdfec->p_aligned_txbuf);
> > > + free(darmdfec->p_rxbuf);
> > > + free(darmdfec->p_rxdesc);
> > > + free(darmdfec->htpr);
> >
> > looks like 4 NULL pointer derefs. so you'll need one specific path
> > for the first malloc(), but the rest are fine.
>
> so you mean like this...
>
> if(!darmdfec)
> goto error;
> ...
> error1:
> free(darmdfec->p_aligned_txbuf);
> free(darmdfec->p_rxbuf);
> free(darmdfec->p_rxdesc);
> free(darmdfec->htpr);
> error:
> free(darmdfec);
> return -1;
that's one way of fixing it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110829/dccb11cf/attachment.pgp
More information about the U-Boot
mailing list