[U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device

Michal Simek monstr at monstr.eu
Mon Aug 29 07:50:32 CEST 2011


Mike Frysinger wrote:
> On Friday, August 26, 2011 08:47:22 Michal Simek wrote:
>> --- a/drivers/net/xilinx_emaclite.c
>> +++ b/drivers/net/xilinx_emaclite.c
>> @@ -356,8 +356,10 @@ int xilinx_emaclite_initialize (bd_t *bis, int
>> base_addr) return -1;
>>
>>  	emaclite = calloc(1, sizeof(struct xemaclite));
>> -	if (emaclite == NULL)
>> +	if (emaclite == NULL) {
>> +		free(dev);
>>  		return -1;
>> +	}
> 
> since this bug was introduced by your patch 5/8, please squash it into that 
> rather than sending out a known buggy one

aah. Good point.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


More information about the U-Boot mailing list