[U-Boot] [PATCH 2/2 v4] powerpc/p1023rds: Disable nor flash node and enable nand flash node

[Wolfgang Denk]

Dear Chunhe Lan,

In message <op.v0ywqdimrxq6oa at localhost.localdomain> you wrote:
> 
> > It would be more intuitive to the reader, when the enabled node would
> > use an explicit
> >
> > 	status = "enabled";
> >
> >> +#ifdef CONFIG_NAND_U_BOOT
> >> +	do_fixup_by_path_string(fdt, "nor_flash", "status", "disabled");
> >> +	do_fixup_by_path_string(fdt, "nand_flash", "status", "okay");
> >> +#endif
> >
> > What does ""okay" mean?  This is not documented anywhere.  Is this
> > supposed to mean "enabled"?  Then please write "enabled" - for certain
> > configurations it is definitely OK to disable the device.
> 
>     In the kernel, whether the status of node is enabled or not, it is  
> determined by
>     of_device_is_available( ).

well, maybe you take my hint to understand that this is not an optimal
implementation?

>           " return 1" is enabled.
>           " return 0" is disabled.
>           So, we do NOT use "enabled" to set status.

This is highly counter-intuitive and fragile.

Also, you fail to comment on my note about the strange "okay" string
in yoru code above - this makes no sense then, either.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The bad reputation UNIX has gotten is totally undeserved, laid on by
people who don't understand, who have not gotten in there  and  tried
anything."          -- Jim Joyce, owner of Jim Joyce's UNIX Bookstore