[U-Boot] [PATCH v2 09/16] ARM: remove broken "versatile" boards.
Albert ARIBAUD
albert.u.boot at aribaud.net
Tue Aug 30 10:24:03 CEST 2011
Stefano,
Le 30/08/2011 10:16, Albert ARIBAUD a écrit :
> Le 30/08/2011 09:16, Stefano Babic a écrit :
>
>> On 08/30/2011 08:47 AM, Albert ARIBAUD wrote:
>>> Hi Stefano,
>>
>> Hi Albert,
>>
>>> Building all versatile boards here with ELDK4.2 on a Natty Ubuntu, I get
>>> warnings of two sorts:
>>>
>>> 1) in the QEMU build, you needlessly cast a pointer as 'volatile',
>>
>> This is wrong...
>>
>>> which
>>> I missed on review but which my compiler does not like -- I did a
>>> general removal patch for code in U-Boot that calls get_ram_size() with
>>> a volatile-cast argument.
>>
>> I saw the same issue rebuilding all IMX board for the scb9328 - because
>> this was the only board with this warning I found, I sent a patch for it
>> and I have already applied to u-boot-imx. I sent to you a "pull
>> request", but let me know if you prefer I drop my patch from u-boot-imx
>> before you merge into u-boot-arm.
>
> I'll pick it with the IMX pull req, and I will apply Wolfgang's patch
> set afterward, minus versatile if the board is completely fixed.
Sorry, I realize there might have been a misunderstanding. The global
fix patch I did was applied some time ago and any spurious volatile left
must be fixed by new patches, so your patch is welcome anyway.
Note that you also need to provide a fix for versatile.c.
Amicalement,
--
Albert.
More information about the U-Boot
mailing list