[U-Boot] [PATCH v2] add dm9000 eeprom read/write command

[Eric Jarrige]

Hi Stefano,

On 30 août 2011, at 11:47, Stefano Babic wrote:

> On 08/28/2011 11:47 PM, Eric Jarrige wrote:
>> Signed-off-by: Eric Jarrige <eric.jarrige at armadeus.org>
>> Signed-off-by: Stefano Babic <sbabic at denx.de>
>> Cc: Wolfgang Denk <wd at denx.de>
>> Cc: Detlev Zundel <dzu at denx.de>
>> 
>> Changes for v2:
>> 	- remove DM9000 driver dependant compilation flag
>> ---
> 
> Hi Eric,
> 
> why should this code put in a separate file and not inserted in the
> driver itself ? I think this remains an open point from our previous
> discussion.
> 

Sorry for the confusion, I did not understood that your remark was
not related to the compilation flags.
Now, I've checked how to have this U-Boot commands in the driver
itself. I think it's doable if  I can have a compilation
CONFIG_CMD_XXX to enable the command line feature.
Without this option, there is a direct impact one memory footprint for
every board featuring the DM9000 controller and I failed to find any
model of driver with an optional command line interface in a driver.

Why do you recommend to put the command interface in drivers
as it is seems to be something quite unusual in U-Boot ? 

Best regards,
Eric