[U-Boot] [PATCH V2] console: Implement pre-console buffer

[Graeme Russ]

Hi Wolfgang

On Wed, Aug 31, 2011 at 9:00 AM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Simon, Mike, Wolfgang,
>
> On Wed, Aug 31, 2011 at 7:02 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Wolfgang,
>>
>> On Tue, Aug 30, 2011 at 1:57 PM, Wolfgang Denk <wd at denx.de> wrote:
>>> Dear Simon Glass,
>>>
>>> In message <CAPnjgZ1dQXMVeFk47=Gg5y+TCHG7WTdGk0b1WjSqOBhu2d0xnQ at mail.gmail.com> you wrote:
>>>>

[snip]

>
> Getting back to gd for a sec - This patch (like the flagify patch set I
> posted before) impacts the structure of gd. Does this trigger in increment
> to the API Version? And as observed before, if the structure of gd is
> fixed for any given API version, then we have a problem with all the
> #ifdef's that are already in gd. If it _is_ the case that the API version
> expects a particular fixed structure for gd, then maybe we need to remove
> all the #ifdefs from gd - Yes it will lead to a few dead ulongs for a few
> boards, but I don't see any practical alternatives. I did think about
> looking at doing some kind of CRC on the gd struct (like the generated
> asm-offsets), but I could not think of a way to do it)

Another gd related thought - Is it safe to assume that gd will be cleared?
I hope so, as the pre-buffer console assumes gd->precon_buf_idx is
initially zero.

Regards,

Graeme