[U-Boot] Common arch-specific header files for SOCs

[Simon Glass]

Hi Mike,

On Tue, Aug 30, 2011 at 9:36 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday, August 30, 2011 17:13:51 Simon Glass wrote:
>> The arch/arm/include/asm/arch symlink needs to point to arch-tegra2 in
>> my case, which is fine, but I also want to be able to include common
>> files.
>>
>> #include <asm/arch/clock.h>
>>
>> This points to arch/arm/include/asm/arch-tegra2/clock.h but this would
>> not be available from a tegra3 architecture, for example.
>
> $ cat arch/arm/include/asm/arch-tegra3/clock.h
> #include <asm/arch-tegra2/clock.h>
>
>> Any other suggestions? It almost feels like we need an 'SOC family'
>> field in boards.cfg (as distinct from SOC). Then we could perhaps have
>> this work automatically.
>
> maybe create asm/arch-tegra/ for the common stuff and have the other tegras
> include that for common stuff ?

That sort-of works. My concern is when drivers start doing

#include <asm/arch-tegra/clock.h>

Doesn't that break the rule that architecture should be set at config
time? Not that it matters much I suppose, since the only drivers
including this file are architecture-specific.

?

Regards,
Simon

> -mike
>