[U-Boot] [PATCH] bootp: Fix bug in auto_load function

[Wolfgang Denk]

Dear Michal Simek,

In message <1314786967-23261-1-git-send-email-monstr at monstr.eu> you wrote:
> Patch: "Put common autoload code into auto_load() function"
> (sha1: 093498669e77597635a24f326f11efeab213d394) is not simple code
> cleanup but code change which introduce new bug.
> 
> If autoload variable is not setup it worked as autoload=yes.

Yes, and this is intentionally, because it's what poople expect when
they run the "dhcpboot" command.

> Currently if autoload is not setup dhcp sends request in
> forever loop.

That's not correct.  Only until a DHCP server provides the needed
configurationinformation so TFTP gets started.

> There are two options how to fix it:
> 1. Move TftpStart() which is in this patch
> 2. Change functionality if autoload is not setup, set NetSate and ends.

That would change behavious in a way that is not wanted.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Status quo. Latin for "the mess we're in."