[U-Boot] [PATCH V4] console: Implement pre-console buffer

[Simon Glass]

Hi Wolfgang,

On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <CAPnjgZ1bMkN3xoNCqtg1CLMa=0rgpHsuyHyZg5yOkR3Hk+v+Bw at mail.gmail.com> you wrote:
>>
>> nit: circular. Just a suggestion if you like: you could also offer
>> guidance for the location of the buffer, something like:
>>
>> You can place the buffer at the top of memory by adding something like
>> this in your board config file:
>>
>> #define CONFIG_PRE_CON_BUF_ADDR               (CONFIG_SYS_INIT_RAM_ADDR + \
>>                                       CONFIG_SYS_INIT_RAM_SIZE - \
>>                                       CONFIG_PRE_CON_BUF_SZ)
>> #define CONFIG_SYS_INIT_SP_ADDR               (CONFIG_PRE_CON_BUF_ADDR - \
>>                                               GENERATED_GBL_DATA_SIZE)
>
> That would only make sense if these were generic options that are used
> across all boards and architectures.

Yes ok - its' already decided not to put this code in arch/xxx/board.c
so let's leave this out then.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> If it went on at this rate, in several billion  years  he'd  be  rich
> beyond his wildest dreams!            - Terry Pratchett, _Soul Music_
>