[U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines.

[Kumar Gala]

On Jan 31, 2011, at 5:36 PM, Timur Tabi wrote:

> On Mon, Jan 31, 2011 at 3:08 PM, Kumar Gala <galak at kernel.crashing.org> wrote:
> 
>>> @@ -588,6 +588,9 @@ typedef struct qe_immap {
>>> #elif defined(CONFIG_MPC8569)
>>>       u8 muram[0x20000];      /* 0x1_0000 -  0x3_0000 Multi-user RAM */
>>>       u8 res17[0x10000];      /* 0x3_0000 -  0x4_0000 */
>>> +#elif defined(CONFIG_P1021)
>>> +     u8 muram[0x06000];      /* 0x1_0000 -  0x1_6000 Multi-user RAM */
>>> +     u8 res17[0x1a000];      /* 0x1_6000 -  0x3_0000 */
>>> #else
>>>       u8 muram[0xC000];       /* 0x110000 -  0x11C000 Multi-user RAM */
>>>       u8 res17[0x24000];      /* 0x11C000 -  0x140000 */
>> 
>> Can we reduce this mess with using QE_MURAM_SIZE?
>> 
>>        u8 muram[QE_MURAM_SIZE];
>>        u8 res17[0xNNNN - QE_MURAM_SIZE];
> 
> I don't think we need res17, because nothing references it.  That will
> simplify it even more.

Looks like qe_immap isn't embedded anywhere so should be ok (was concerned if the struct is expected to be a given size.

- k