[U-Boot] [PATCH 1/3] MIPS: VCT: Fix enabling of unwanted options if networking or USB support are disabled

Daniel Schwierzeck daniel.schwierzeck at googlemail.com
Thu Feb 3 13:31:19 CET 2011


Hi Stefan,

>
>> * Only Premium/Platinum have ethernet support right now
>
>> */
>
>> -#if defined(CONFIG_VCT_PREMIUM) || defined(CONFIG_VCT_PLATINUM)
>
>> +#if (defined(CONFIG_VCT_PREMIUM) || defined(CONFIG_VCT_PLATINUM)) && \
>
>> + !defined CONFIG_VCT_SMALL_IMAGE
>
> I would prefer consistent style with braces around CONFIG_VCT_SMALL_IMAGE
> here.
Ok I'll change this.

>
>> #define CONFIG_CMD_PING
>
>> #define CONFIG_CMD_SNTP
>
>> #else
>
>> #undef CONFIG_CMD_NET
>
>> +#undef CONFIG_CMD_NFS
>
>> #endif
>
>>
>
>> /*
>
>> * Only Premium/Platinum have USB-EHCI support right now
>
>> */
>
>> -#if defined(CONFIG_VCT_PREMIUM) || defined(CONFIG_VCT_PLATINUM)
>
>> +#if (defined(CONFIG_VCT_PREMIUM) || defined(CONFIG_VCT_PLATINUM)) && \
>
>> + !defined CONFIG_VCT_SMALL_IMAGE
>
> Same here. Otherwise:
Dito.

Thanks

Daniel


More information about the U-Boot mailing list