[U-Boot] [PATCH] Add support for ASIX's AX88783 ethernet chip

[Stefano Babic]

On 02/04/2011 03:47 PM, Joe XUE wrote:
>> Do not forget to add always the net Maintainer to CC (Wolfgang Denk), I
>> added him now.
>> 
> 
> Not exactly understand your meaning. You mean I should add wd as
> maintainer to my code or 
> just add him in mail.

Only add him in mail. He is the maintainer for net code.

>> From the name it seems you set the controller in loopback, instead of
>> disabling it. Is it correct ?
>> 
> 
> mmn. I just make it can't receive the data outside.
> The other way is make it into sleep mode.

I do not know your chip, I cannot help. However, this function is
thought to put the controller in a not operative state. It is a good law
to leave your hardware disable and let the kernel to reinitialize it
again when your system boots.

> I refer to the newest net driver patch ftgmac100.c, it uses this
> function to get
> mac address from environmental setting. and I checked the
> code eth_getenv_enetaddr
> also call the is_valid_ether_addr(). 

I checked this driver, too.IMHO it is wrong, and I do not know why in
ftgmac100_set_mac_from_env() is called getenv instead of using directly
the values in dev->enetaddr. Anyway, I missed my chance to send my
comments ;-)

You can check in other drivers in drivers/net, most of them do not call
getenv, because the net subsystem is responsible to do this.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================