[U-Boot] [PATCH 4/4 v2] p1021mds: add QE and UEC support

Haiying Wang Haiying.Wang at freescale.com
Tue Feb 8 18:11:32 CET 2011


On Tue, 2011-02-08 at 12:09 -0500, Haiying Wang wrote:
> On Tue, 2011-02-08 at 10:52 -0600, Kumar Gala wrote:
> 
> 
> > > +#endif
> > > 
> > > 	uec = (uec_private_t *)dev->priv;
> > > 
> > > 	if (uec->the_first_run == 0) {
> > > +#ifdef CONFIG_P1021
> > > +	/* reset micrel phy for each UEC */
> > > +	clrbits_8((u8 *)(CONFIG_SYS_BCSR_BASE + 11), BCSR11_ENET_MICRST);
> > > +	udelay(200);
> > > +	setbits_8((u8 *)(CONFIG_SYS_BCSR_BASE + 11), BCSR11_ENET_MICRST);
> > > +
> > 
> > Hmm, this is board specific, can we not do this in board_*_f or _r?
> > 
> It did not work to do this in board_*_f/r. The board designer to me to
:%s/to me/told me/

> reset the phy before initializing it for each UEC separately. Here is
> the right place to do so.

Haiying 





More information about the U-Boot mailing list