[U-Boot] [PATCH 1/1] NAND Re: mtdparts fails with NAND >= 4GB - Second try
Aaron Williams
Aaron.Williams at caviumnetworks.com
Wed Feb 9 00:11:54 CET 2011
On Tuesday, February 08, 2011 07:38:44 am Andrew Dyer wrote:
> On Mon, Feb 7, 2011 at 16:58, Scott Wood <scottwood at freescale.com> wrote:
> > On Mon, Jan 31, 2011 at 06:56:48PM -0800, Aaron Williams wrote:
> >> Trying again submitting the patch.
> >>
> >> /* Do manufacturer-specific fixups */
> >> switch (info->manufacturer_id) {
> >> + case 0x0000:
> >> case 0x0001:
> >> flash_fixup_amd(info, &qry);
> >> break;
> >
> > This seems unrelated.
> >
> > Otherwise, the patch looks good. Whose tree should it go through?
> > It's not really a NAND patch, though NAND is the reason for it.
>
> NAK
>
> This is not only unrelated (which the OP was told to fix on the
> previous post of this patch), but wrong. The S29GL series chips don't
> return 0x0000 for the manufacturer ID. AMD (later Spansion) have
> always had mfg. ID 0x0001.
>
> I have various boards with S29GL064, S29GL128N, and S29GL256P, and
> they all return the correct value (0x0001) for the mfg. ID. I looked
> up the latest datasheet and they have not changed that section.
I always get 0x0000 for the mfg ID and cannot explain it. The full part number
is S29GL064N90TF103 010FF058. That is why it was added. Without it, the proper
fixup doesn't happen with this chip.
-Aaron
More information about the U-Boot
mailing list