[U-Boot] [PATCH] Kirkwood: Add support for OpenRD-Client & OpenRD-Ultimate

[Prafulla Wadaskar]

> -----Original Message-----
> From: Tanmay Upadhyay - Embedded [mailto:tanmay.upadhyay at einfochips.com]
> Sent: Wednesday, February 09, 2011 1:18 AM
> To: Prafulla Wadaskar
> Cc: Prabhanjan Sarnaik; Ashish Karkare; Julian Pidancet; u-
> boot at lists.denx.de
> Subject: Re: [PATCH] Kirkwood: Add support for OpenRD-Client & OpenRD-
> Ultimate
> 
> 
> ----- Original Message -----
> From: "Prafulla Wadaskar" <prafulla at marvell.com>
> To: "Julian Pidancet" <julian.pidancet at citrix.com>, u-boot at lists.denx.de
> Cc: "tanmay upadhyay" <tanmay.upadhyay at einfochips.com>, "Prabhanjan
> Sarnaik" <sarnaik at marvell.com>, "Ashish Karkare" <akarkare at marvell.com>
> Sent: Wednesday, February 9, 2011 12:16:40 PM
> Subject: RE: [PATCH] Kirkwood: Add support for OpenRD-Client & OpenRD-
> Ultimate
> 
> 
> 
> > -----Original Message-----
> > From: Julian Pidancet [mailto:julian.pidancet at citrix.com]
> > Sent: Tuesday, February 08, 2011 10:21 AM
> > To: u-boot at lists.denx.de
> > Cc: tanmay.upadhyay at einfochips.com; Prafulla Wadaskar
> > Subject: [PATCH] Kirkwood: Add support for OpenRD-Client & OpenRD-
> > Ultimate
> >
> > This patch modifies existing OpenRD-Base support to deal with all
> > the three OpenRD boards (OpenRD-Base, OpenRD-Client & OpenRD-
> Ultimate).
> >
> > This is a rebase onto master from an original patch sent by Tanmay
> > Upadhyay a few months ago.
> > All credits goes to him.
> > It's been tested on my OpenRD-Ultimate and works perfectly fine.
> >
> > Signed-off-by: Julian Pidancet <julian.pidancet at citrix.com>
> > <mailto:julian.pidancet at citrix.com>
> > ---
> >  MAKEALL                                 |    2 +
> >  board/Marvell/openrd/Makefile           |   56 ++++++++++
> >  board/Marvell/openrd/config.mk          |   33 ++++++
> >  board/Marvell/openrd/kwbimage.cfg       |  168
> > ++++++++++++++++++++++++++++++
> >  board/Marvell/openrd/openrd.c           |  173
> > +++++++++++++++++++++++++++++++
> >  board/Marvell/openrd/openrd.h           |   50 +++++++++
> >  board/Marvell/openrd_base/Makefile      |   56 ----------
> >  board/Marvell/openrd_base/kwbimage.cfg  |  168 ----------------------
> --
> > ------
> >  board/Marvell/openrd_base/openrd_base.c |  153 ----------------------
> --
> > ---
> >  board/Marvell/openrd_base/openrd_base.h |   46 --------
> >  boards.cfg                              |    4 +-
> >  include/configs/openrd.h                |  115 ++++++++++++++++++++
> >  include/configs/openrd_base.h           |   92 +++--------------
> >  include/configs/openrd_client.h         |   50 +++++++++
> >  include/configs/openrd_ultimate.h       |   50 +++++++++
> >  15 files changed, 714 insertions(+), 502 deletions(-)
> >  create mode 100644 board/Marvell/openrd/Makefile
> >  create mode 100644 board/Marvell/openrd/config.mk
> >  create mode 100644 board/Marvell/openrd/kwbimage.cfg
> >  create mode 100644 board/Marvell/openrd/openrd.c
> >  create mode 100644 board/Marvell/openrd/openrd.h
> >  delete mode 100644 board/Marvell/openrd_base/Makefile
> >  delete mode 100644 board/Marvell/openrd_base/kwbimage.cfg
> >  delete mode 100644 board/Marvell/openrd_base/openrd_base.c
> >  delete mode 100644 board/Marvell/openrd_base/openrd_base.h
> >  create mode 100644 include/configs/openrd.h
> >  create mode 100644 include/configs/openrd_client.h
> >  create mode 100644 include/configs/openrd_ultimate.h
> 
> Hi Julian
> 
> I suggest not to delete old file, on the other hand you can rename or
> move them through git.
> 
> Regards...
> Prafulla . .
> 
> 
> 
> Hi Prafulla,
> 
> In original patch I had moved files with 'git mv' command, but the patch
> showed up like this. Am I missing appropriate git command?

Better you split your patch into two,
1. move/rename of existing code only.
2. Patch to add additional two board supports.

Regards..
Prafulla . .