[U-Boot] [PATCH ATMEL REWORK] update arm/at91rm9200 work with rework rework110202

[Jens Scharsig]

Dear Andreas Bießmann,

I'm offline for the net 10 days. So I fast include your comments to a V2 patch version

Am 11.02.2011 09:11, schrieb Andreas Bießmann:
> Dear Jens Scharsig,
> 
> Am 10.02.2011 um 20:31 schrieb Jens Scharsig:
> 
>> * update arm920t/at91 to ATMEL_xxx name scheme
>> * convert at91rm9200ek and eb_cpux9k2 board to ATMEL_xxx name scheme
>> * update arm920t/at91 soc lib
>> * update at91_emac driver
>>
>> Signed-off-by: Jens Scharsig <js_at_ng at scharsoft.de>
> 
> Tested-by: Andreas Bießmann <andreas.devel at gmail.com>
> 
> But some changes

I have prepare a second version of my patch.
> 
>> ---
>>
>> The eb_cpux9k2 board can compile and runs after patch changes
>> The at91rm9200ek can compile, but i have no hardware to test it.
> 
> at91rm9200ek is working but the change for timer.c is needed

The timer.c changes I sent i a previous patch. I have join them to V2
>  Testet peripheral for at91rm9200ek is:
>   - USB (fatls)
>   - EMAC (tftp)
> 
>>
>> +#define CONFIG_AT91FAMILY	/* it's a member of AT91 */
>> +#define CONFIG_ARM920T		/* This is an ARM920T Core	*/
>> +
> 
> These are defined in board header .. I saw they are defined also in other at91xxx.h files, we should discuss where to define these since all of the at91xx.h files are included by hardware.h

In V2 a have remove the define from board config's
> 
>> /* Periperial Identifiers */
> 
> [snip changes to at91rm9200.h which are obviously OK]
> 
>> +#define ATMEL_PIO_PORTS		4	/* theese SoCs have 3 PIO */
> 
> 3 or 4 PIO?

3 for PLCC and 4 for BGA variants. In PLCC the 4th port is not bound out. 
I set the comment to 4 in V2

>>
>> +
> 
> please remove this additional empty line

removed
> 
>> #define CONFIG_DRIVER_AT91EMAC		1
>> #define CONFIG_DRIVER_AT91EMAC_QUIET	1
>> +/*
>> +#define CONFIG_DRIVER_MACB		1
>> +*/
> 
> why this? Either it is needed or not.
> 
waste from testing, removed

Best regard 

Jens Scharsig