[U-Boot] [PATCH 1/3] Add Atmel USBA UDC
Wolfgang Denk
wd at denx.de
Sat Feb 12 20:09:23 CET 2011
Dear Marcel Janssen,
In message <1297527588-21530-1-git-send-email-korgull at home.nl> you wrote:
> From: Marcel <korgull at home.nl>
>
> Signed-off-by: Marcel <korgull at home.nl>
>
> Added Atmel USBA UDC to Makefile
>
> Signed-off-by: Marcel <korgull at home.nl>
> ---
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/atmel_usba_udc.c | 1586 +++++++++++++++++++++++++++++++++++
> include/usb/atmel_usba_udc.h | 469 +++++++++++
> 3 files changed, 2056 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/gadget/atmel_usba_udc.c
> create mode 100644 include/usb/atmel_usba_udc.h
Will you please stop posting random patch series without any
additional information???
Remo wrote already yesterday:
|
| How does this patch relate to the patch you posted yesterday?
| That one modified a Makefile as well, while this one does not?!
| If you make a new version of a patch, please add the proper version
| info and changelog to the newer patch as described here:
| http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
But you ignore all advice and post one patch seires after the other,
without markign these by some version number, without adding any
change log so we can see what might have been changed.
You are supposed to follow the rules.
And before reposting, please make sure to run your patchjes through
checkpatch and fix all the errors:
[U-Boot] [PATCH 1/4] Add Atmel USBA UDC
total: 323 errors, 117 warnings, 2055 lines checked
[U-Boot] [PATCH 2/4] Add Atmel USBA UDC
OK, 7 lines checked
[U-Boot] [PATCH 3/4] add USB DFU driver
total: 247 errors, 91 warnings, 1713 lines checked
[U-Boot] [PATCH 4/4] add icnova sam9g45 board
total: 105 errors, 37 warnings, 1077 lines checked
[U-Boot] [PATCH 1/3] Add Atmel USBA UDC
total: 323 errors, 117 warnings, 2062 lines checked
[U-Boot] [PATCH 2/3] add USB DFU driver
total: 247 errors, 91 warnings, 1713 lines checked
[U-Boot] [PATCH 3/3] add icnova sam9g45 board
total: 105 errors, 37 warnings, 1087 lines checked
Please consider ALL you patches rejected.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The joys of love made her human and the agonies of love destroyed
her.
-- Spock, "Requiem for Methuselah", stardate 5842.8
More information about the U-Boot
mailing list