[U-Boot] [PATCH] powerpc: clean up DIU macro definitions for the MPC8610HPCD and MPC5121ADS

Wolfgang Denk wd at denx.de
Tue Feb 15 22:30:42 CET 2011


Dear Timur Tabi,

In message <1297804966-21532-1-git-send-email-timur at freescale.com> you wrote:
> Clean up the macro defintions used to enable DIU (video) support on the
> MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS,
> which is newer.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>  include/configs/MPC8610HPCD.h |   12 ++++--------
>  include/configs/mpc5121ads.h  |    8 ++++----
>  2 files changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h
> index 03ee394..d28e29b 100644
> --- a/include/configs/MPC8610HPCD.h
> +++ b/include/configs/MPC8610HPCD.h
> @@ -21,12 +21,13 @@
>  
>  #define	CONFIG_SYS_TEXT_BASE	0xfff00000
>  
> -#define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  /* video */
> -#undef CONFIG_VIDEO
> +#undef CONFIG_FSL_DIU_FB

Please do not undef what is not defiend anyway.

...
> diff --git a/include/configs/mpc5121ads.h b/include/configs/mpc5121ads.h
> index f966325..72c8e3f 100644
> --- a/include/configs/mpc5121ads.h
> +++ b/include/configs/mpc5121ads.h
> @@ -46,14 +46,15 @@
>   */
>  #define CONFIG_E300		1	/* E300 Family */
>  #define CONFIG_MPC512X		1	/* MPC512X family */
> -#define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
>  
>  #define	CONFIG_SYS_TEXT_BASE	0xFFF00000
>  
>  /* video */
> -#undef CONFIG_VIDEO
> +#undef CONFIG_FSL_DIU_FB

Ditto.

And please put the respective arch custodians on Cc:

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is common sense to take a method and try it. If it fails, admit it
frankly and try another. But above all, try something.
                                              - Franklin D. Roosevelt


More information about the U-Boot mailing list