[U-Boot] [PATCH] [v2] powerpc: clean up DIU macro definitions for the MPC8610HPCD and MPC5121ADS

Wolfgang Denk wd at denx.de
Tue Feb 15 23:15:03 CET 2011


Dear Timur Tabi,

In message <4D5AF8A8.2010902 at freescale.com> you wrote:
> Wolfgang Denk wrote:
> >> >  /* video */
> >> > -#undef CONFIG_VIDEO
> >> > +/* #define CONFIG_FSL_DIU_FB */
> > Please do not add dead code.
> 
> It's not dead code.  It's a comment that tells people how to enable video support.

It is dead code. Please remove it.

Documentation is already present in the README, isn't it?

Ouch - gotcha!  Please fix _that_.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The high cost of living hasn't affected its popularity.


More information about the U-Boot mailing list